From 51910dc65ae965b92d2cfe6a4d28df4ad27288a2 Mon Sep 17 00:00:00 2001 From: Tien Long Lam Date: Mon, 15 Aug 2022 03:07:01 +1000 Subject: [PATCH] Added tickers in the reader page slider Default setting is off, under the reader page --- .../eu/kanade/tachiyomi/data/preference/PreferencesHelper.kt | 2 ++ .../java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt | 1 + .../kanade/tachiyomi/ui/setting/SettingsReaderController.kt | 5 +++++ app/src/main/res/values/strings.xml | 2 ++ 4 files changed, 10 insertions(+) diff --git a/app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferencesHelper.kt b/app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferencesHelper.kt index 09343e2eaf..56fa132fdc 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferencesHelper.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferencesHelper.kt @@ -153,6 +153,8 @@ class PreferencesHelper(val context: Context) { fun showNavigationOverlayOnStart() = flowPrefs.getBoolean("reader_navigation_overlay_on_start", false) + fun showSliderTickers() = flowPrefs.getBoolean("reader_slider_tickers", false) + fun readerHideThreshold() = flowPrefs.getEnum("reader_hide_threshold", Values.ReaderHideThreshold.LOW) fun portraitColumns() = flowPrefs.getInt("pref_library_columns_portrait_key", 0) diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt index a1b6725333..94f558fc7b 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderActivity.kt @@ -640,6 +640,7 @@ class ReaderActivity : BaseRxActivity() { binding.toolbar.title = manga.title binding.pageSlider.isRTL = newViewer is R2LPagerViewer + binding.pageSlider.isTickVisible = preferences.showSliderTickers().get() if (newViewer is R2LPagerViewer) { binding.leftChapter.setTooltip(R.string.action_next_chapter) binding.rightChapter.setTooltip(R.string.action_previous_chapter) diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsReaderController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsReaderController.kt index a67f72831c..f22105bfa1 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsReaderController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsReaderController.kt @@ -57,6 +57,11 @@ class SettingsReaderController : SettingsController() { titleRes = R.string.pref_show_navigation_mode summaryRes = R.string.pref_show_navigation_mode_summary } + switchPreference { + bindTo(preferences.showSliderTickers()) + titleRes = R.string.pref_show_slider_tickers + summaryRes = R.string.pref_show_slider_tickers_summary + } if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { switchPreference { bindTo(preferences.trueColor()) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index e65e818f02..c99087f3c4 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -293,6 +293,8 @@ Fullscreen Show tap zones overlay Briefly show when reader is opened + Show slider tickers + Show tickers representing pages in the page slider Dual page split Invert dual page split placement If the placement of the dual page split doesn\'t match reading direction