From 9e2ef82902369908503e860af12e8536a004bd43 Mon Sep 17 00:00:00 2001
From: arkon <eugcheung94@gmail.com>
Date: Mon, 18 Oct 2021 09:54:09 -0400
Subject: [PATCH] Remove global update intervals below 12 hours, add every 3
 day interval

Users with smaller libraries have a lower change of getting updates frequently. "Power users" are actively hurting sources by updating frequently.
---
 app/build.gradle.kts                                      | 2 +-
 app/src/main/java/eu/kanade/tachiyomi/Migrations.kt       | 8 ++++++++
 .../tachiyomi/ui/setting/SettingsLibraryController.kt     | 7 ++-----
 app/src/main/res/values/strings.xml                       | 4 +---
 4 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index cdd2f5c9fc..f380939440 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -29,7 +29,7 @@ android {
         minSdk = AndroidConfig.minSdk
         targetSdk = AndroidConfig.targetSdk
         testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
-        versionCode = 70
+        versionCode = 71
         versionName = "0.12.3"
 
         buildConfigField("String", "COMMIT_COUNT", "\"${getCommitCount()}\"")
diff --git a/app/src/main/java/eu/kanade/tachiyomi/Migrations.kt b/app/src/main/java/eu/kanade/tachiyomi/Migrations.kt
index a68762fa8a..fe4d13a51d 100644
--- a/app/src/main/java/eu/kanade/tachiyomi/Migrations.kt
+++ b/app/src/main/java/eu/kanade/tachiyomi/Migrations.kt
@@ -235,6 +235,14 @@ object Migrations {
                     preferences.enabledLanguages() += "all"
                 }
             }
+            if (oldVersion < 71) {
+                // Handle removed every 3, 4, 6, and 8 hour library updates
+                val updateInterval = preferences.libraryUpdateInterval().get()
+                if (updateInterval in listOf(3, 4, 6, 8)) {
+                    preferences.libraryUpdateInterval().set(12)
+                    LibraryUpdateJob.setupTask(context, 12)
+                }
+            }
 
             return true
         }
diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsLibraryController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsLibraryController.kt
index 6e4fd5c8ca..a8e98b3236 100644
--- a/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsLibraryController.kt
+++ b/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsLibraryController.kt
@@ -139,16 +139,13 @@ class SettingsLibraryController : SettingsController() {
                 titleRes = R.string.pref_library_update_interval
                 entriesRes = arrayOf(
                     R.string.update_never,
-                    R.string.update_3hour,
-                    R.string.update_4hour,
-                    R.string.update_6hour,
-                    R.string.update_8hour,
                     R.string.update_12hour,
                     R.string.update_24hour,
                     R.string.update_48hour,
+                    R.string.update_72hour,
                     R.string.update_weekly
                 )
-                entryValues = arrayOf("0", "3", "4", "6", "8", "12", "24", "48", "168")
+                entryValues = arrayOf("0", "12", "24", "48", "72", "168")
                 defaultValue = "24"
                 summary = "%s"
 
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 1ef9c7bb47..d87ecd186d 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -211,13 +211,11 @@
     <string name="pref_category_library_update">Global update</string>
     <string name="pref_library_update_interval">Update frequency</string>
     <string name="update_never">Manual</string>
-    <string name="update_3hour">Every 3 hours</string>
-    <string name="update_4hour">Every 4 hours</string>
     <string name="update_6hour">Every 6 hours</string>
-    <string name="update_8hour">Every 8 hours</string>
     <string name="update_12hour">Every 12 hours</string>
     <string name="update_24hour">Daily</string>
     <string name="update_48hour">Every 2 days</string>
+    <string name="update_72hour">Every 3 days</string>
     <string name="update_weekly">Weekly</string>
     <string name="pref_library_update_prioritization">Update order</string>
     <string name="pref_library_update_restriction">Update restrictions</string>