DataHearth/yuzu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

shader: Fix use-after-free bug in object_pool

Browse Source
This commit is contained in:
ReinUsesLisp 2021-03-23 22:07:14 -03:00 committed by ameerj
parent 3d07cef009
commit 1d2db78398
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/shader_recompiler/object_pool.h
View File

@ -18,7 +18,7 @@ public:
} }
template <typename... Args> template <typename... Args>
requires std::is_constructible_v<T, Args...>[[nodiscard]] T* Create(Args&&... args) { requires std::is_constructible_v<T, Args...> [[nodiscard]] T* Create(Args&&... args) {
return std::construct_at(Memory(), std::forward<Args>(args)...); return std::construct_at(Memory(), std::forward<Args>(args)...);
} }
@ -32,12 +32,12 @@ public:
const size_t total_objects{root.num_objects + new_chunk_size * (chunks.size() - 1)}; const size_t total_objects{root.num_objects + new_chunk_size * (chunks.size() - 1)};
chunks.clear(); chunks.clear();
chunks.emplace_back(total_objects); chunks.emplace_back(total_objects);
chunks.shrink_to_fit();
} else { } else {
root.Release(); root.Release();
chunks.resize(1); chunks.resize(1);
chunks.shrink_to_fit();
} }
chunks.shrink_to_fit();
node = &chunks.front();
} }
private: private: