From 29b6afb82f39a9f21389e2d9ee65ff6cdd909db8 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Thu, 2 Aug 2018 21:41:51 -0400 Subject: [PATCH] input_common: Add missing override specifiers --- src/input_common/keyboard.cpp | 2 +- src/input_common/motion_emu.cpp | 2 +- src/input_common/sdl/sdl.cpp | 12 ------------ 3 files changed, 2 insertions(+), 14 deletions(-) diff --git a/src/input_common/keyboard.cpp b/src/input_common/keyboard.cpp index 0f0d10f237..0410ff3288 100644 --- a/src/input_common/keyboard.cpp +++ b/src/input_common/keyboard.cpp @@ -14,7 +14,7 @@ public: explicit KeyButton(std::shared_ptr key_button_list_) : key_button_list(key_button_list_) {} - ~KeyButton(); + ~KeyButton() override; bool GetStatus() const override { return status.load(); diff --git a/src/input_common/motion_emu.cpp b/src/input_common/motion_emu.cpp index caffe48cbd..9570c060eb 100644 --- a/src/input_common/motion_emu.cpp +++ b/src/input_common/motion_emu.cpp @@ -131,7 +131,7 @@ public: device = std::make_shared(update_millisecond, sensitivity); } - std::tuple, Math::Vec3> GetStatus() const { + std::tuple, Math::Vec3> GetStatus() const override { return device->GetStatus(); } diff --git a/src/input_common/sdl/sdl.cpp b/src/input_common/sdl/sdl.cpp index 8d117c2d4f..604d9a7d92 100644 --- a/src/input_common/sdl/sdl.cpp +++ b/src/input_common/sdl/sdl.cpp @@ -314,10 +314,6 @@ namespace Polling { class SDLPoller : public InputCommon::Polling::DevicePoller { public: - SDLPoller() = default; - - ~SDLPoller() = default; - void Start() override { // SDL joysticks must be opened, otherwise they don't generate events SDL_JoystickUpdate(); @@ -341,10 +337,6 @@ private: class SDLButtonPoller final : public SDLPoller { public: - SDLButtonPoller() = default; - - ~SDLButtonPoller() = default; - Common::ParamPackage GetNextInput() override { SDL_Event event; while (SDL_PollEvent(&event)) { @@ -364,10 +356,6 @@ public: class SDLAnalogPoller final : public SDLPoller { public: - SDLAnalogPoller() = default; - - ~SDLAnalogPoller() = default; - void Start() override { SDLPoller::Start();