From 881bb2295d40c50a401cd05fff8eeb822ec577e9 Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Wed, 10 Oct 2018 20:59:25 -0400
Subject: [PATCH] telemetry_json: Take std::string parameters by value

Taking them by const reference isn't advisable here, because it means
the std::move calls were doing nothing and we were always copying the
std::string instances.
---
 src/web_service/telemetry_json.cpp | 3 +--
 src/web_service/telemetry_json.h   | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/web_service/telemetry_json.cpp b/src/web_service/telemetry_json.cpp
index e77950aa3b..b24e806a89 100644
--- a/src/web_service/telemetry_json.cpp
+++ b/src/web_service/telemetry_json.cpp
@@ -8,8 +8,7 @@
 
 namespace WebService {
 
-TelemetryJson::TelemetryJson(const std::string& host, const std::string& username,
-                             const std::string& token)
+TelemetryJson::TelemetryJson(std::string host, std::string username, std::string token)
     : host(std::move(host)), username(std::move(username)), token(std::move(token)) {}
 TelemetryJson::~TelemetryJson() = default;
 
diff --git a/src/web_service/telemetry_json.h b/src/web_service/telemetry_json.h
index 72627a4167..92ead9856c 100644
--- a/src/web_service/telemetry_json.h
+++ b/src/web_service/telemetry_json.h
@@ -18,7 +18,7 @@ namespace WebService {
  */
 class TelemetryJson : public Telemetry::VisitorInterface {
 public:
-    TelemetryJson(const std::string& host, const std::string& username, const std::string& token);
+    TelemetryJson(std::string host, std::string username, std::string token);
     ~TelemetryJson();
 
     void Visit(const Telemetry::Field<bool>& field) override;