From 89ebef65719a95cbd43385efde56d3e83fade290 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 1 Aug 2018 23:50:45 -0400 Subject: [PATCH] sink_details: std::move std::function instances Given std::function is allowed to potentially allocate, these should be std::move'd to prevent potential reallocation (should that ever happen). --- src/audio_core/sink_details.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/audio_core/sink_details.h b/src/audio_core/sink_details.h index aa8aae1a99..4f90277621 100644 --- a/src/audio_core/sink_details.h +++ b/src/audio_core/sink_details.h @@ -6,6 +6,7 @@ #include #include +#include #include namespace AudioCore { @@ -15,7 +16,7 @@ class Sink; struct SinkDetails { SinkDetails(const char* id_, std::function(std::string)> factory_, std::function()> list_devices_) - : id(id_), factory(factory_), list_devices(list_devices_) {} + : id(id_), factory(std::move(factory_)), list_devices(std::move(list_devices_)) {} /// Name for this sink. const char* id;