Used better names for mm:u and fixed bad stub

InitializeWithId needs to return an id which is a u32 which should be a non zero value
This commit is contained in:
David Marcec 2018-10-19 01:09:34 +11:00
parent 7dee60d7d2
commit 98c7a6d622

View File

@ -14,14 +14,14 @@ public:
explicit MM_U() : ServiceFramework{"mm:u"} { explicit MM_U() : ServiceFramework{"mm:u"} {
// clang-format off // clang-format off
static const FunctionInfo functions[] = { static const FunctionInfo functions[] = {
{0, &MM_U::Initialize, "InitializeOld"}, {0, &MM_U::Initialize, "Initialize"},
{1, &MM_U::Finalize, "FinalizeOld"}, {1, &MM_U::Finalize, "Finalize"},
{2, &MM_U::SetAndWait, "SetAndWaitOld"}, {2, &MM_U::SetAndWait, "SetAndWait"},
{3, &MM_U::Get, "GetOld"}, {3, &MM_U::Get, "Get"},
{4, &MM_U::Initialize, "Initialize"}, {4, &MM_U::InitializeWithId, "InitializeWithId"},
{5, &MM_U::Finalize, "Finalize"}, {5, &MM_U::FinalizeWithId, "FinalizeWithId"},
{6, &MM_U::SetAndWait, "SetAndWait"}, {6, &MM_U::SetAndWaitWithId, "SetAndWaitWithId"},
{7, &MM_U::Get, "Get"}, {7, &MM_U::GetWithId, "GetWithId"},
}; };
// clang-format on // clang-format on
@ -59,9 +59,43 @@ private:
rb.Push(current); rb.Push(current);
} }
void InitializeWithId(Kernel::HLERequestContext& ctx) {
LOG_WARNING(Service_MM, "(STUBBED) called");
IPC::ResponseBuilder rb{ctx, 3};
rb.Push(RESULT_SUCCESS);
rb.Push<u32>(id); // Any non zero value
}
void FinalizeWithId(Kernel::HLERequestContext& ctx) {
LOG_WARNING(Service_MM, "(STUBBED) called");
IPC::ResponseBuilder rb{ctx, 2};
rb.Push(RESULT_SUCCESS);
}
void SetAndWaitWithId(Kernel::HLERequestContext& ctx) {
IPC::RequestParser rp{ctx};
u32 input_id = rp.Pop<u32>();
min = rp.Pop<u32>();
max = rp.Pop<u32>();
current = min;
LOG_WARNING(Service_MM, "(STUBBED) called, input_id=0x{:X}, min=0x{:X}, max=0x{:X}",
input_id, min, max);
IPC::ResponseBuilder rb{ctx, 2};
rb.Push(RESULT_SUCCESS);
}
void GetWithId(Kernel::HLERequestContext& ctx) {
LOG_WARNING(Service_MM, "(STUBBED) called");
IPC::ResponseBuilder rb{ctx, 3};
rb.Push(RESULT_SUCCESS);
rb.Push(current);
}
u32 min{0}; u32 min{0};
u32 max{0}; u32 max{0};
u32 current{0}; u32 current{0};
u32 id{1};
}; };
void InstallInterfaces(SM::ServiceManager& service_manager) { void InstallInterfaces(SM::ServiceManager& service_manager) {