diff --git a/src/common/thread_worker.cpp b/src/common/thread_worker.cpp index 745918c7e0..f4d8bb0f0d 100644 --- a/src/common/thread_worker.cpp +++ b/src/common/thread_worker.cpp @@ -8,36 +8,30 @@ namespace Common { ThreadWorker::ThreadWorker(std::size_t num_workers, const std::string& name) { - for (std::size_t i = 0; i < num_workers; ++i) - threads.emplace_back([this, thread_name{std::string{name}}] { - Common::SetCurrentThreadName(thread_name.c_str()); + const auto lambda = [this, thread_name{std::string{name}}] { + Common::SetCurrentThreadName(thread_name.c_str()); - // Wait for first request + while (!stop) { + UniqueFunction task; { std::unique_lock lock{queue_mutex}; - condition.wait(lock, [this] { return stop || !requests.empty(); }); - } - - while (true) { - std::function task; - - { - std::unique_lock lock{queue_mutex}; - condition.wait(lock, [this] { return stop || !requests.empty(); }); - if (stop || requests.empty()) { - return; - } - task = std::move(requests.front()); - requests.pop(); - - if (requests.empty()) { - wait_condition.notify_one(); - } + if (requests.empty()) { + wait_condition.notify_all(); } - - task(); + condition.wait(lock, [this] { return stop || !requests.empty(); }); + if (stop || requests.empty()) { + break; + } + task = std::move(requests.front()); + requests.pop(); } - }); + task(); + } + wait_condition.notify_all(); + }; + for (size_t i = 0; i < num_workers; ++i) { + threads.emplace_back(lambda); + } } ThreadWorker::~ThreadWorker() { @@ -51,10 +45,10 @@ ThreadWorker::~ThreadWorker() { } } -void ThreadWorker::QueueWork(std::function&& work) { +void ThreadWorker::QueueWork(UniqueFunction work) { { std::unique_lock lock{queue_mutex}; - requests.emplace(work); + requests.emplace(std::move(work)); } condition.notify_one(); } diff --git a/src/common/thread_worker.h b/src/common/thread_worker.h index 7a6756eb5f..7e2b04a071 100644 --- a/src/common/thread_worker.h +++ b/src/common/thread_worker.h @@ -11,18 +11,20 @@ #include #include +#include "common/unique_function.h" + namespace Common { class ThreadWorker final { public: explicit ThreadWorker(std::size_t num_workers, const std::string& name); ~ThreadWorker(); - void QueueWork(std::function&& work); + void QueueWork(UniqueFunction work); void WaitForRequests(); private: std::vector threads; - std::queue> requests; + std::queue> requests; std::mutex queue_mutex; std::condition_variable condition; std::condition_variable wait_condition;