From 0c53cc52bd3050fa000188ae6472659a402c6893 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Fri, 30 Jan 2015 11:28:09 -0500 Subject: [PATCH 1/3] apt_u: Fix missing printf specifiers --- src/core/hle/service/apt_u.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/hle/service/apt_u.cpp b/src/core/hle/service/apt_u.cpp index 629b670eda..4c3f621d05 100644 --- a/src/core/hle/service/apt_u.cpp +++ b/src/core/hle/service/apt_u.cpp @@ -373,7 +373,7 @@ void SetAppCpuTimeLimit(Service::Interface* self) { u32 percent = cmd_buff[2]; if (value != 1) { - LOG_ERROR(Service_APT, "This value must be one!", value); + LOG_ERROR(Service_APT, "This value should be one, but is actually %u!", value); } cmd_buff[1] = RESULT_SUCCESS.raw; // No error @@ -395,7 +395,7 @@ void GetAppCpuTimeLimit(Service::Interface* self) { u32 value = cmd_buff[1]; if (value != 1) { - LOG_ERROR(Service_APT, "This value must be one!", value); + LOG_ERROR(Service_APT, "This value should be one, but is actually %u!", value); } // TODO(purpasmart96): This is incorrect, I'm pretty sure the percentage should From 551264f815e019996d0c3599e40219e75095a670 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Fri, 30 Jan 2015 11:30:22 -0500 Subject: [PATCH 2/3] archive: Fix initializer list order for the File class. --- src/core/hle/service/fs/archive.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/hle/service/fs/archive.cpp b/src/core/hle/service/fs/archive.cpp index 6682f6590d..43eef034ed 100644 --- a/src/core/hle/service/fs/archive.cpp +++ b/src/core/hle/service/fs/archive.cpp @@ -89,7 +89,7 @@ public: class File : public Kernel::Session { public: File(std::unique_ptr&& backend, const FileSys::Path& path) - : path(path), backend(std::move(backend)), priority(0) { + : path(path), priority(0), backend(std::move(backend)) { } std::string GetName() const override { return "Path: " + path.DebugStr(); } From 0c4685ca12b091220f62f800474fd25a2a39d1ad Mon Sep 17 00:00:00 2001 From: Lioncash Date: Fri, 30 Jan 2015 11:33:20 -0500 Subject: [PATCH 3/3] loader: Add missing printf argument --- src/core/loader/loader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/loader/loader.cpp b/src/core/loader/loader.cpp index 60460292d2..52730a7b43 100644 --- a/src/core/loader/loader.cpp +++ b/src/core/loader/loader.cpp @@ -150,7 +150,7 @@ ResultStatus LoadFile(const std::string& filename) { // IdentifyFile could know identify file type... case FileType::Unknown: { - LOG_CRITICAL(Loader, "File %s is of unknown type."); + LOG_CRITICAL(Loader, "File %s is of unknown type.", filename.c_str()); return ResultStatus::ErrorInvalidFormat; } }