From ebb82b0b8394781622afe132a0779dc25995b47b Mon Sep 17 00:00:00 2001 From: Morph <39850852+Morph1984@users.noreply.github.com> Date: Tue, 6 Jul 2021 12:48:49 -0400 Subject: [PATCH] CMakeLists: Treat -Wsign-compare as an error on GCC/Clang Treats (un)signed comparison mismatches as errors to be consistent with MSVC --- src/CMakeLists.txt | 1 + src/audio_core/CMakeLists.txt | 3 --- src/core/CMakeLists.txt | 2 -- src/input_common/CMakeLists.txt | 3 --- 4 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 65a4922ea9..f8ec8fea8c 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -82,6 +82,7 @@ else() -Werror=missing-declarations -Werror=missing-field-initializers -Werror=reorder + -Werror=sign-compare -Werror=switch -Werror=uninitialized -Werror=unused-function diff --git a/src/audio_core/CMakeLists.txt b/src/audio_core/CMakeLists.txt index d25a1a6451..090dd19b1d 100644 --- a/src/audio_core/CMakeLists.txt +++ b/src/audio_core/CMakeLists.txt @@ -51,9 +51,6 @@ if (NOT MSVC) target_compile_options(audio_core PRIVATE -Werror=conversion -Werror=ignored-qualifiers - -Werror=implicit-fallthrough - -Werror=reorder - -Werror=sign-compare -Werror=shadow -Werror=unused-parameter -Werror=unused-variable diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt index 19b970981e..b2b0dbe051 100644 --- a/src/core/CMakeLists.txt +++ b/src/core/CMakeLists.txt @@ -667,8 +667,6 @@ else() target_compile_options(core PRIVATE -Werror=conversion -Werror=ignored-qualifiers - -Werror=implicit-fallthrough - -Werror=sign-compare -Werror=shadow $<$:-Werror=class-memaccess> diff --git a/src/input_common/CMakeLists.txt b/src/input_common/CMakeLists.txt index c3423c815d..c4283a9526 100644 --- a/src/input_common/CMakeLists.txt +++ b/src/input_common/CMakeLists.txt @@ -44,10 +44,7 @@ else() -Werror -Werror=conversion -Werror=ignored-qualifiers - -Werror=implicit-fallthrough - -Werror=reorder -Werror=shadow - -Werror=sign-compare $<$:-Werror=unused-but-set-parameter> $<$:-Werror=unused-but-set-variable> -Werror=unused-variable