From f2a680ca893f29fc35135986ad56b961205d610e Mon Sep 17 00:00:00 2001 From: Lioncash Date: Fri, 28 Aug 2020 21:14:51 -0400 Subject: [PATCH] sdl_impl: Make use of std::move on std::string where applicable Avoids redundant copies. --- src/input_common/sdl/sdl_impl.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/input_common/sdl/sdl_impl.cpp b/src/input_common/sdl/sdl_impl.cpp index 85fcd457cb..8d83184d2d 100644 --- a/src/input_common/sdl/sdl_impl.cpp +++ b/src/input_common/sdl/sdl_impl.cpp @@ -577,7 +577,7 @@ Common::ParamPackage BuildAnalogParamPackageForButton(int port, std::string guid float value = 0.1f) { Common::ParamPackage params({{"engine", "sdl"}}); params.Set("port", port); - params.Set("guid", guid); + params.Set("guid", std::move(guid)); params.Set("axis", axis); if (value > 0) { params.Set("direction", "+"); @@ -592,7 +592,7 @@ Common::ParamPackage BuildAnalogParamPackageForButton(int port, std::string guid Common::ParamPackage BuildButtonParamPackageForButton(int port, std::string guid, u8 button) { Common::ParamPackage params({{"engine", "sdl"}}); params.Set("port", port); - params.Set("guid", guid); + params.Set("guid", std::move(guid)); params.Set("button", button); return params; } @@ -601,7 +601,7 @@ Common::ParamPackage BuildHatParamPackageForButton(int port, std::string guid, u Common::ParamPackage params({{"engine", "sdl"}}); params.Set("port", port); - params.Set("guid", guid); + params.Set("guid", std::move(guid)); params.Set("hat", hat); switch (value) { case SDL_HAT_UP: